check for retention period to be a multiple of periodic table duration and relevant test #1564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rather than silently changing what the user asked for, we could just make this an error. |
sandeepsukhani
force-pushed
the
retention-tables-count-fix
branch
2 times, most recently
from
433e25c to
2a43403
Compare
sandeepsukhani
changed the title
gouthamve
approved these changes
Aug 12, 2019
tomwilkie
reviewed
Aug 14, 2019
tomwilkie
approved these changes
Aug 14, 2019
…uration and relevant test Signed-off-by: Sandeep Sukhani <[email protected]>
sandeepsukhani
force-pushed
the
retention-tables-count-fix
branch
from
28b2cfd to
4da3673
Compare
gouthamve
reviewed
Aug 14, 2019
gouthamve
reviewed
Aug 14, 2019
Signed-off-by: Sandeep Sukhani <[email protected]>
gouthamve
reviewed
Aug 14, 2019
Signed-off-by: Sandeep Sukhani <[email protected]>
Signed-off-by: Sandeep Sukhani <[email protected]>
gouthamve
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the retention period is not a multiple of periodic table duration, we need to error out since Cortex doesn't yet support partial deletion of tables.
Added a check to validate retention against the latest config(assuming the last one is the latest) and relevant test.
Signed-off-by: Sandeep Sukhani [email protected]