Add a histogram for cached value sizes. #1569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Wilkie <[email protected]>
tomwilkie
force-pushed
the
cached-value-sizes
branch
from
4b31383 to
15d7297
Compare
Signed-off-by: Tom Wilkie <[email protected]>
gouthamve
approved these changes
Aug 13, 2019
bboreham
reviewed
Aug 16, 2019
| @@ -108,6 +108,7 @@ type decodeResponse struct { | |||
|
|
|||
| // NewChunkFetcher makes a new ChunkFetcher. | |||
| func NewChunkFetcher(cfg cache.Config, cacheStubs bool, storage ObjectClient) (*Fetcher, error) { | |||
| cfg.Prefix = "chunks" | |||
There was a problem hiding this comment.
This has the effect that the name label in cortex_cache_hits changes from "memcache" to "chunksmemcache".
Which is a (minor) breaking change that should go in the changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tom Wilkie [email protected]