Chunk time ranges are inclusive. #1576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Wilkie <[email protected]>
Signed-off-by: Tom Wilkie <[email protected]>
Signed-off-by: Tom Wilkie <[email protected]>
Signed-off-by: Tom Wilkie <[email protected]>
tomwilkie
force-pushed
the
1522-chunkstorerandom-flake
branch
from
1843e9e to
b700996
Compare
bboreham
reviewed
Aug 13, 2019
| @@ -602,8 +602,8 @@ func TestChunkStoreRandom(t *testing.T) { | |||
|
|
|||
| // pick two random numbers and do a query | |||
| for i := 0; i < 100; i++ { | |||
| start := rand.Int63n(100 * chunkLen) | |||
| end := start + 1 + rand.Int63n((100*chunkLen)-start) | |||
| start := rand.Int63n(99 * chunkLen) | |||
There was a problem hiding this comment.
why do we want this change?
There was a problem hiding this comment.
At the end of the list of chunks there are no more chunks. It simplifies the test logic below to ensuring we never query over the end of the list of chunks.
Not specifically, but we've been running this for ~3 weeks and not found any problems. |
|
Turns out I was thinking of a very similar line in LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1522 "ChunkStoreRandom Flake".
I believe this was a real bug - queries that ended on exact day boundaries wouldn't query chunks which started on exact day boundaries.