Small optimisations to Ingester.append() #1654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `stopped` is only used in one place, that is already taking a lock, re-use that lock and skip the effort to check the other lock and defer unlock it. Signed-off-by: Bryan Boreham <[email protected]>
Each defer involves some memory allocation and housekeeping - since they are right next to one another we can save half the effort. Signed-off-by: Bryan Boreham <[email protected]>
csmarchbanks
approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stoppedis only used in one place, that is already taking a lock, re-useuserStatesMtxand skip the effort to check thestopLockanddefer Unlockit.defers into one - eachdeferinvolves some memory allocation and housekeeping so we can save half the effort.