Skip to content

Complete update to go 1.13 #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2019

Conversation

gouthamve
Copy link
Contributor

Changes the image in circleci config and updates vendor.

Signed-off-by: Goutham Veeramachaneni [email protected]

@codesome
Copy link
Contributor

Explicit proxy can also be removed from Makefile

cortex/Makefile

Lines 148 to 151 in 114312d

GO111MODULE=on GOPROXY=https://proxy.golang.org go mod download
GO111MODULE=on GOPROXY=https://proxy.golang.org go mod verify
GO111MODULE=on GOPROXY=https://proxy.golang.org go mod tidy
GO111MODULE=on GOPROXY=https://proxy.golang.org go mod vendor

it's the default in 1.13 now.

Changes the image in circleci config and updates vendor.

Signed-off-by: Goutham Veeramachaneni <[email protected]>
Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gouthamve gouthamve merged commit 9d6c4d1 into cortexproject:master Sep 18, 2019
@gouthamve gouthamve deleted the update-1-13-part-2 branch September 18, 2019 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants