Fix for flaky test. #1770
Merged
Fix for flaky test. #1770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure we get most notifications, but not necessarily all. Signed-off-by: Peter Štibraný <[email protected]>
pracucci
reviewed
Oct 31, 2019
Timeout for entire test is now longer, but we end early if there is no value for 500ms. We again check that all keys were received exactly once, no room for exceptions. Signed-off-by: Peter Štibraný <[email protected]>
pracucci
reviewed
Oct 31, 2019
Signed-off-by: Peter Štibraný <[email protected]>
pracucci
approved these changes
Oct 31, 2019
Thanks @pracucci for your review and feedback! |
gouthamve
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test failure reported by @gouthamve, after recent merge of PR #1756:
Test was too strict. Now it checks that we receive most notifications, but not necessarily all.Test watches for changes under prefix "test/" and expect single change in every key between 0-100.
It failed because it didn't wait long enough. Now it waits for longer time, but stops as soon it receives all notifications. Also watching for changes starts before generator starts, so that first changes can't possibly be missed.