Don't return 500's for KV CAS calls if the CAS returned an HTTP status code. #1798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addition of the HA tracking code. If the return error of the CAS has an HTTP status code, we should return that. This will resolve the issue of the KV metrics showing 500's for all writes from the non-elected Prometheus replicas. Signed-off-by: Callum Styan <[email protected]>
cstyan
changed the title
pstibrany
approved these changes
Nov 8, 2019
pstibrany
reviewed
Nov 8, 2019
| if err == nil { | ||
| return "200" | ||
| } | ||
| if resp, ok := httpgrpc.HTTPResponseFromError(err); ok { |
There was a problem hiding this comment.
This only works for errors from GRPC layer. I don't think etcd or consul use GRPC. Update: etcd v3 does!
|
@pstibrany This change is to allow us to differentiate between actual errors and short circuit exits from CAS calls within the HA tracking code: https://github.com/cortexproject/cortex/blob/master/pkg/distributor/ha_tracker.go#L237-L239 |
tomwilkie
approved these changes
Nov 9, 2019
gouthamve
approved these changes
Nov 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CAS calls to the KV store can return HTTP status codes since the addition of the HA tracking code.
If the return error of the CAS has an HTTP status code, we should return that. This will resolve the issue of the KV metrics showing 500's for all writes from the non-elected Prometheus replicas.
Signed-off-by: Callum Styan [email protected]
@tomwilkie