Removed support for writing denormalised tokens in the ring. #1809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
reviewed
Nov 11, 2019
pstibrany
changed the title
Merged
pracucci
approved these changes
Nov 18, 2019
There was a problem hiding this comment.
Good job @pstibrany! Changes LGTM. I just left a non blocking comment.
codesome
reviewed
Dec 4, 2019
|
@gouthamve why 'type/breaking' label? We know that upgrade to normalised tokens works fine, and so making them mandatory won't break anything. (Perhaps if someone is upgrading from VERY old Cortex versions that didn't support normalisation at all?) [Update: upgrade would still work in such case!] |
gouthamve
reviewed
Dec 12, 2019
Still supported: - claiming tokens from another ingester, that is using denormalised tokens - finding denormalised tokens in the ring, when joining Other ingesters can still use denormalised tokens, migrateRing takes care of that. Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
gouthamve
approved these changes
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed support for writing denormalised tokens in the ring.
Still supported:
Other ingesters can still use denormalised tokens, migrateRing takes care of that.
Targeted for Cortex 0.5.0.
No changelog written yet.Issue #1787
Fixes #1877