-
Notifications
You must be signed in to change notification settings - Fork 817
Removed support for writing denormalised tokens in the ring. #1809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @pstibrany! Changes LGTM. I just left a non blocking comment.
@gouthamve why 'type/breaking' label? We know that upgrade to normalised tokens works fine, and so making them mandatory won't break anything. (Perhaps if someone is upgrading from VERY old Cortex versions that didn't support normalisation at all?) [Update: upgrade would still work in such case!] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor nits. Thanks for this change Peter!
Still supported: - claiming tokens from another ingester, that is using denormalised tokens - finding denormalised tokens in the ring, when joining Other ingesters can still use denormalised tokens, migrateRing takes care of that. Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased on top of master.
Removed support for writing denormalised tokens in the ring.
Still supported:
Other ingesters can still use denormalised tokens, migrateRing takes care of that.
Targeted for Cortex 0.5.0.
No changelog written yet.Issue #1787
Fixes #1877