Skip to content

Removed support for writing denormalised tokens in the ring. #1809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 12, 2019
Merged

Removed support for writing denormalised tokens in the ring. #1809

merged 13 commits into from
Dec 12, 2019

Conversation

pstibrany
Copy link
Contributor

@pstibrany pstibrany commented Nov 11, 2019

Removed support for writing denormalised tokens in the ring.

Still supported:

  • claiming tokens from another ingester, that is using denormalised tokens
  • finding denormalised tokens in the ring, when joining

Other ingesters can still use denormalised tokens, migrateRing takes care of that.

Targeted for Cortex 0.5.0. No changelog written yet.

Issue #1787
Fixes #1877

@pstibrany pstibrany changed the title Removed support for using denormalised tokens in the ring. Removed support for writing denormalised tokens in the ring. Nov 11, 2019
@pracucci pracucci mentioned this pull request Nov 11, 2019
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @pstibrany! Changes LGTM. I just left a non blocking comment.

@pstibrany
Copy link
Contributor Author

pstibrany commented Dec 6, 2019

@gouthamve why 'type/breaking' label? We know that upgrade to normalised tokens works fine, and so making them mandatory won't break anything. (Perhaps if someone is upgrading from VERY old Cortex versions that didn't support normalisation at all?) [Update: upgrade would still work in such case!]

Copy link
Contributor

@jtlisi jtlisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gouthamve gouthamve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor nits. Thanks for this change Peter!

Still supported:
- claiming tokens from another ingester, that is using denormalised tokens
- finding denormalised tokens in the ring, when joining

Other ingesters can still use denormalised tokens, migrateRing takes care
of that.

Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Copy link
Contributor Author

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased on top of master.

@gouthamve gouthamve merged commit 1c5ff0c into cortexproject:master Dec 12, 2019
@pstibrany pstibrany deleted the normalized-tokens branch December 18, 2019 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent behaviour of Desc.AddIngester
5 participants