Show ingester tokens after button click in ring status page #1810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Open question: the page HTML still includes all the tokens. I'm wondering if want we want is to hide them (like you did) or do not include them at all in the page (so that we don't have to download them) unless a query string parameter is passed (which can be passed clicking a button in the page). |
Signed-off-by: Ankit Goel <[email protected]>
goelankitt
force-pushed
the
ring_page
branch
from
da9328e to
29a309d
Compare
|
Thanks for the PR @ankit1ank I second @pracucci 's comment - it would be good to cut down the amount of data transferred. |
Signed-off-by: Ankit Goel <[email protected]>
|
Made the required changes. Please review. |
pracucci
approved these changes
Nov 21, 2019
pstibrany
approved these changes
Nov 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR improves the ring status page. It shows the ingester tokens only when a button is pressed.
Which issue(s) this PR fixes:
Fixes #759