Added tests covering TSDB read path in the ingester #1838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pracucci
changed the title
codesome
reviewed
Nov 19, 2019
| }, | ||
| } | ||
|
|
||
| return req, expectedResponse |
There was a problem hiding this comment.
I don't see expectedResponse being used anywhere
There was a problem hiding this comment.
This function is a copy and paste from #1830 (still under review). Keeping the copy and paste will help me rebasing once one of the two PRs will get merged.
|
@codesome I've replied/addressed your comments. May you take another look, please? |
codesome
approved these changes
Nov 19, 2019
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
pracucci
force-pushed
the
test-ingester-tsdb-read-path
branch
from
2440f2b to
b772128
Compare
|
@gouthamve I've fixed the conflicts after rebasing. May you help me moving forward with this PR, please? |
gouthamve
approved these changes
Dec 5, 2019
bboreham
approved these changes
Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
While working on PR #1830 I've realized we don't have any test on the TSDB read path in the ingester. In this PR I'm adding them.
Which issue(s) this PR fixes:
No issue for this
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]