Skip to content

Added tests covering TSDB read path in the ingester #1838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pracucci
Copy link
Contributor

What this PR does:
While working on PR #1830 I've realized we don't have any test on the TSDB read path in the ingester. In this PR I'm adding them.

Which issue(s) this PR fixes:
No issue for this

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@pracucci
Copy link
Contributor Author

Copy link
Contributor

@thorfour thorfour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pracucci pracucci changed the title Added tests coverting TSDB read path in the ingester Added tests covering TSDB read path in the ingester Nov 18, 2019
},
}

return req, expectedResponse
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see expectedResponse being used anywhere

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is a copy and paste from #1830 (still under review). Keeping the copy and paste will help me rebasing once one of the two PRs will get merged.

@pracucci
Copy link
Contributor Author

@codesome I've replied/addressed your comments. May you take another look, please?

@pracucci pracucci force-pushed the test-ingester-tsdb-read-path branch from 2440f2b to b772128 Compare December 4, 2019 10:58
@pracucci
Copy link
Contributor Author

pracucci commented Dec 4, 2019

@gouthamve I've fixed the conflicts after rebasing. May you help me moving forward with this PR, please?

@gouthamve gouthamve merged commit 84a1e28 into cortexproject:master Dec 5, 2019
@pracucci pracucci deleted the test-ingester-tsdb-read-path branch December 6, 2019 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants