-
Notifications
You must be signed in to change notification settings - Fork 817
Added tests covering TSDB read path in the ingester #1838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tests covering TSDB read path in the ingester #1838
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
}, | ||
} | ||
|
||
return req, expectedResponse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see expectedResponse
being used anywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is a copy and paste from #1830 (still under review). Keeping the copy and paste will help me rebasing once one of the two PRs will get merged.
@codesome I've replied/addressed your comments. May you take another look, please? |
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
2440f2b
to
b772128
Compare
@gouthamve I've fixed the conflicts after rebasing. May you help me moving forward with this PR, please? |
What this PR does:
While working on PR #1830 I've realized we don't have any test on the TSDB read path in the ingester. In this PR I'm adding them.
Which issue(s) this PR fixes:
No issue for this
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]