Do not close and re-open TSDBs during ingester transfer #1854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorfour
suggested changes
Nov 25, 2019
pstibrany
approved these changes
Nov 26, 2019
pstibrany
approved these changes
Nov 26, 2019
|
@thorfour May you check it out again and - if you don't have any further comment and you're good with it - approve it, please? Otherwise feel free to take more time to think about it or comment. |
|
@pracucci will take a look first thing Monday |
pracucci
force-pushed
the
fix-queries-while-transferring-tsdb-on-ingester-leaving
branch
from
0d5dd4c to
5e84cc4
Compare
|
@gouthamve and @thorfour I've fixed the conflicts after rebasing. May you take a look and help this PR moving forward, please? |
gouthamve
approved these changes
Dec 5, 2019
pracucci
force-pushed
the
fix-queries-while-transferring-tsdb-on-ingester-leaving
branch
from
36819ba to
5d9e956
Compare
…shutdown Signed-off-by: Marco Pracucci <[email protected]>
…ter shutdown Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
…nstead of a timeout Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
…ler more info about the reasion Signed-off-by: Marco Pracucci <[email protected]>
…ight requests to complete in the ingester's TSDB transfer Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
pracucci
force-pushed
the
fix-queries-while-transferring-tsdb-on-ingester-leaving
branch
from
5d9e956 to
f449a43
Compare
Signed-off-by: Marco Pracucci <[email protected]>
pracucci
deleted the
fix-queries-while-transferring-tsdb-on-ingester-leaving
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
The Cortex TSDB experimental integration currently close all TSDBs during the ingester shutdown, before blocks and WALs are transferred to a joining ingester. This has two main issues:
open index reader: block is closingMe and @codesome checked out the TSDB implementation and came to the conclusion which is safe to transfer blocks as WAL without closing the TSDB as far as:
In this PR I've introduced some changes to avoid closing and re-opening TSDBs on queries received during ingester blocks/WAL transfer, as well as some logic to guarantee no writes occur to the TSDB once the transfer starts.
I've tested the changes in our TSDB test cluster and looks working as expected (at least, experimentally).
Suggestion to the reviewer: enable "Hide whitespace changes" because there are a couple of large code blocks for which it has changed only the indentation.
Which issue(s) this PR fixes:
Fixes #1829
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]