Skip to content

Add tools to the build image to build the website #1858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 28, 2019
Merged

Add tools to the build image to build the website #1858

merged 2 commits into from
Nov 28, 2019

Conversation

cyriltovena
Copy link
Contributor

Required for #1851

@cyriltovena
Copy link
Contributor Author

/cc @bboreham @jtlisi Can I get a quick review to move the website forward. This is required to test circleci on the other PR.

jtlisi
jtlisi approved these changes Nov 27, 2019
View reviewed changes
Copy link
Contributor

@jtlisi jtlisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bboreham
bboreham approved these changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm slightly scared how much bigger this will make the build container, but I guess we can figure that out over time.

@cyriltovena
Copy link
Contributor Author

cyriltovena commented Nov 28, 2019 •
edited
Loading

@bboreham

quay.io/cortexproject/build-image website-build-image-17abbcd5-WIP 1.79GB
cortexproject/build-image master-94ba16ade 1.01GB

700MB more for hugo and npm. I think if this is a problem we can split images.

Although compressed the current version is at 300MB https://hub.docker.com/layers/cortexproject/build-image/master-94ba16ade/images/sha256-bfbe4f2412207158ced052faec18a0aacf5ed686e0ea00f9b0c0b553a824a1a4

@cyriltovena
Copy link
Contributor Author

This is ready, if someone can push that image to docker hub once it merged it would be great so I can keep testing the CI for the website.

@cyriltovena
Copy link
Contributor Author

Seems that there is a flakky test for the CAS. I'll rebase to retrigger

@cyriltovena
Cleanup hugo installation.
f8fbb9d 
Signed-off-by: Cyril Tovena <[email protected]>
@bboreham bboreham merged commit 0f3143d into cortexproject:master Nov 28, 2019
@pstibrany
Copy link
Contributor

Seems that there is a flakky test for the CAS. I'll rebase to retrigger

I cannot find this failed check anywhere. Any chance you remember details?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtlisi jtlisi jtlisi approved these changes

@bboreham bboreham bboreham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cyriltovena @pstibrany @jtlisi @bboreham