-
Notifications
You must be signed in to change notification settings - Fork 817
Add tools to the build image to build the website #1858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tools to the build image to build the website #1858
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm slightly scared how much bigger this will make the build container, but I guess we can figure that out over time.
quay.io/cortexproject/build-image website-build-image-17abbcd5-WIP 1.79GB 700MB more for hugo and npm. I think if this is a problem we can split images. Although compressed the current version is at 300MB https://hub.docker.com/layers/cortexproject/build-image/master-94ba16ade/images/sha256-bfbe4f2412207158ced052faec18a0aacf5ed686e0ea00f9b0c0b553a824a1a4 |
This is ready, if someone can push that image to docker hub once it merged it would be great so I can keep testing the CI for the website. |
Seems that there is a flakky test for the CAS. I'll rebase to retrigger |
Signed-off-by: Cyril Tovena <[email protected]>
652eca2
to
d7c0151
Compare
Signed-off-by: Cyril Tovena <[email protected]>
I cannot find this failed check anywhere. Any chance you remember details? |
Required for #1851