Skip to content

Do not consider PENDING state as healthy #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Do not consider PENDING state as healthy #1866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/ring/model.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ func (d *Desc) TokensFor(id string) (tokens, other []uint32) {
func (i *IngesterDesc) IsHealthy(op Operation, heartbeatTimeout time.Duration) bool {
if op == Write && i.State != ACTIVE {
return false
} else if op == Read && i.State == JOINING {
} else if op == Read && i.State != ACTIVE && i.State != LEAVING {
return false
}
return time.Now().Sub(time.Unix(i.Timestamp, 0)) <= heartbeatTimeout
Expand Down
12 changes: 12 additions & 0 deletions pkg/ring/model_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,18 @@ func TestIngesterDesc_IsHealthy(t *testing.T) {
writeExpected: false,
readExpected: true,
},
"PENDING ingester with last keepalive newer than timeout": {
ingester: &IngesterDesc{State: PENDING, Timestamp: time.Now().Add(-30 * time.Second).Unix()},
timeout: time.Minute,
writeExpected: false,
readExpected: false,
},
"LEFT ingester with last keepalive newer than timeout": {
ingester: &IngesterDesc{State: LEFT, Timestamp: time.Now().Add(-30 * time.Second).Unix()},
timeout: time.Minute,
writeExpected: false,
readExpected: false,
},
}

for testName, testData := range tests {
Expand Down