Skip to content

Fix redirects on /ring page by using relative targets. #1896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 11, 2019
Merged

Fix redirects on /ring page by using relative targets. #1896

merged 4 commits into from
Dec 11, 2019

Conversation

pstibrany
Copy link
Contributor

@pstibrany pstibrany commented Dec 10, 2019

What this PR does: This PR changes redirects from /ring page to use relative links, instead of path-absolute. This is useful when running distributor HTTP server behind reverse proxy, which maps it to a different path than root.

Checklist

  • Tests updated - nope, tested manually
  • Documentation added - nope
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bboreham
Copy link
Contributor

Fixes #778, at least in part.

Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit.

@gouthamve gouthamve merged commit d8a9646 into cortexproject:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants