pkg/distributor: shardByAllLabels didn't check for label names order correctly #1957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…correctly shardByAllLabels had a check to verify if labels are sorted properly, but it didn't set lastLabelName, so it was comparing label names against empty string only. Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
|
This change affects only if |
pracucci
approved these changes
Jan 7, 2020
Yes. Recently I've seen someone pointing out that we are not consistent about this check at various code paths. If only I remembered where it was. I believe that we should disallow unsorted labels everywhere consistently. |
gouthamve
approved these changes
Jan 7, 2020
2 tasks
gouthamve
added a commit
that referenced
this pull request
Jan 9, 2020
…s order correctly (#1957)" This reverts commit f49eb9e. Signed-off-by: Goutham Veeramachaneni <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shardByAllLabelshad a check to verify if labels are sorted properly, but it didn't setlastLabelName, so it was comparing label names against empty string only.