add flag to enable and set the mutex profile fraction #1969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Lisi <[email protected]>
pracucci
reviewed
Jan 10, 2020
CHANGELOG.md
Outdated
| @@ -14,6 +14,7 @@ | |||
| * [CHANGE] Ingesters now write only normalised tokens to the ring, although they can still read denormalised tokens used by other ingesters. `-ingester.normalise-tokens` is now deprecated, and ignored. If you want to switch back to using denormalised tokens, you need to downgrade to Cortex 0.4.0. Previous versions don't handle claiming tokens from normalised ingesters correctly. #1809 | |||
| * [CHANGE] Overrides mechanism has been renamed to "runtime config", and is now separate from limits. Runtime config is simply a file that is reloaded by Cortex every couple of seconds. Limits and now also multi KV use this mechanism.<br />New arguments were introduced: `-runtime-config.file` (defaults to empty) and `-runtime-config.reload-period` (defaults to 10 seconds), which replace previously used `-limits.per-user-override-config` and `-limits.per-user-override-period` options. Old options are still used if `-runtime-config.file` is not specified. This change is also reflected in YAML configuration, where old `limits.per_tenant_override_config` and `limits.per_tenant_override_period` fields are replaced with `runtime_config.file` and `runtime_config.period` respectively. #1749 | |||
| * [FEATURE] The distributor can now drop labels from samples (similar to the removal of the replica label for HA ingestion) per user via the `distributor.drop-label` flag. #1726 | |||
| * [FEATURE] Added flag to enable mutex profiling | |||
There was a problem hiding this comment.
A couple of things, please:
- Add the new flag name
- Add the PR
cmd/cortex/main.go
Outdated
| ) | ||
| flag.StringVar(&configFile, "config.file", "", "Configuration file to load.") | ||
| flag.IntVar(&eventSampleRate, "event.sample-rate", 0, "How often to sample observability events (0 = never).") | ||
| flag.IntVar(&ballastBytes, "mem-ballast-size-bytes", 0, "Size of memory ballast to allocate.") | ||
| flag.IntVar(&mutexProfileFraction, "mutex-profile-fraction", 0, "Fraction at which mutex profile vents will be reported, 0 to disable") |
There was a problem hiding this comment.
What if we prefix it with debug. (so the flag will be -debug.mutex-profile-fraction) to explicitly state it's a flag just used for debugging?
Signed-off-by: Jacob Lisi <[email protected]>
pracucci
approved these changes
Jan 10, 2020
khaines
approved these changes
Jan 13, 2020
gouthamve
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds the ability to enable/set mutex profiling in the go runtime.
Which issue(s) this PR fixes:
In the past when profiling cortex, especially the ingesters, I have wanted to view a mutex profile. This PR adds the ability to do that.
Checklist
CHANGELOG.mdupdated