-
Notifications
You must be signed in to change notification settings - Fork 817
Experimental TSDB: Enable Azure Storage Backend #2083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental TSDB: Enable Azure Storage Backend #2083
Conversation
Signed-off-by: Ken Haines <[email protected]>
b9262ea
to
ef78ab8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @khaines! It's lovely to see you jumping on the blocks storage too! I left few minor comments related to doc/config which I would like to see them addressed before merging 🙏
579be55
to
956205c
Compare
Signed-off-by: Ken Haines <[email protected]>
Signed-off-by: Ken Haines <[email protected]>
956205c
to
1e5679a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @khaines for addressing my feedback. A couple of last inconsistencies in the doc and we should be good to go
Signed-off-by: Ken Haines <[email protected]>
Thanks for the attention to detail on the documentation @pracucci ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the attention to detail on the documentation @pracucci !
Thanks to you for being so far iterating on feedback! LGTMerged 😉
What this PR does: Adds the needed cortex structs and configuration to enable azure storage usage with the experimental tsdb engine.
I've got a small cluster using this currently as it's storage backend, but it's still relatively new so I would say testing for this over the long term is still ongoing.
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]