Skip to content

Experimental TSDB: Enable Azure Storage Backend #2083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 6, 2020

Conversation

khaines
Copy link
Contributor

@khaines khaines commented Feb 5, 2020

What this PR does: Adds the needed cortex structs and configuration to enable azure storage usage with the experimental tsdb engine.

I've got a small cluster using this currently as it's storage backend, but it's still relatively new so I would say testing for this over the long term is still ongoing.

Checklist

  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@khaines khaines force-pushed the khaines/tsdb-azure-storage branch 3 times, most recently from b9262ea to ef78ab8 Compare February 6, 2020 05:16
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @khaines! It's lovely to see you jumping on the blocks storage too! I left few minor comments related to doc/config which I would like to see them addressed before merging 🙏

@khaines khaines force-pushed the khaines/tsdb-azure-storage branch from 579be55 to 956205c Compare February 6, 2020 15:35
@khaines khaines force-pushed the khaines/tsdb-azure-storage branch from 956205c to 1e5679a Compare February 6, 2020 15:38
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @khaines for addressing my feedback. A couple of last inconsistencies in the doc and we should be good to go

@khaines
Copy link
Contributor Author

khaines commented Feb 6, 2020

Thanks for the attention to detail on the documentation @pracucci !

Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the attention to detail on the documentation @pracucci !

Thanks to you for being so far iterating on feedback! LGTMerged 😉

@pracucci pracucci merged commit ec2d25b into cortexproject:master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants