Skip to content

Stop table-manager loop early, if it is done #2121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 13, 2020
Merged

Stop table-manager loop early, if it is done #2121

merged 3 commits into from
Feb 13, 2020

Conversation

pstibrany
Copy link
Contributor

This is trivial fix that helps integration tests to run slightly faster, as discussed at #2016 (review).

If table-manager is stopped during initial wait, it now exits early.

Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pstibrany. This PR looks based on a fairly old version of master. May you rebase it, please?

Signed-off-by: Peter Štibraný <[email protected]>
@pstibrany
Copy link
Contributor Author

Thanks @pstibrany. This PR looks based on a fairly old version of master. May you rebase it, please?

Done. How did you even find out? You had to manually check my source branch I guess :)

@pracucci
Copy link
Contributor

How did you even find out?

I checked out the PR to test it. I can see a failed integration test in CI. May you take a look, please?

Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pstibrany
Copy link
Contributor Author

Thanks!

Worth noting: I haven't fixed the failing integration test. I think single-binary test with memberlist is flaky. I just added observed value into the error message. That said, I think it's unrelated to this change.

@pracucci pracucci merged commit 3f35196 into cortexproject:master Feb 13, 2020
@pracucci
Copy link
Contributor

Worth noting: I haven't fixed the failing integration test. I think single-binary test with memberlist is flaky. I just added observed value into the error message. That said, I think it's unrelated to this change.

Sure. But the log you've added may help to investigate it, as soon as we're able to reproduce it.

@pstibrany pstibrany deleted the table-manager-fix branch February 13, 2020 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants