Skip to content

Memberlist integration test fix #2127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 13, 2020
Merged

Memberlist integration test fix #2127

merged 5 commits into from
Feb 13, 2020

Conversation

pstibrany
Copy link
Contributor

What this PR does:
This PR does 2+1 things:

  • It makes Memberlist KV store to wait a little bit on shutdown to increase the chance of sending out messages caused by local CAS updates.
  • It modifies memberlist integration test to use 3s for push/pull mechanism. Default is 30s. Push/pull transfers full state between two random nodes. It makes cluster convergence faster, which speeds up the test and avoids flakiness.
  • It also changes usage of older github.com/uber-go/atomic 1.4.0 to go.uber.org/atomic 1.5.0. Both refer to the same package, but "go.uber.org/atomic" is a new module name.

pracucci
pracucci approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a couple of comments (up to you)

@pstibrany
Review feedback.
ee82988 
Signed-off-by: Peter Štibraný <[email protected]>
jtlisi
jtlisi approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@jtlisi jtlisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pracucci pracucci merged commit 7c601a4 into cortexproject:master Feb 13, 2020
@pstibrany pstibrany deleted the memberlist-integration-test-fix branch February 13, 2020 14:45
This was referenced Feb 13, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pracucci pracucci pracucci approved these changes

@jtlisi jtlisi jtlisi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pstibrany @pracucci @jtlisi