Fix default_validity cache setting typo #2140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trevor Wood <[email protected]>
pracucci
approved these changes
Feb 17, 2020
There was a problem hiding this comment.
Thanks for your contribution! I'm in favour of fixing this config typo even if it means introducing a breaking change.
May you rebase master to fix CI tests, please?
@slim-bean @cyriltovena Please be aware this change will also affect Loki.
tomwilkie
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Trevor Wood [email protected]
What this PR does:
Fixes a typo in the YAML configuration for caches. Currently, the setting is
defaul_validity, but it should bedefault_validity.Which issue(s) this PR fixes:
Fixes #1842
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]