tsdb: expose stripe size option to reduce tsdb memory footprint #2185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorfour
force-pushed
the
feat/tsdb-stripe-size
branch
2 times, most recently
from
d751087 to
f55a530
Compare
pstibrany
approved these changes
Feb 26, 2020
thorfour
force-pushed
the
feat/tsdb-stripe-size
branch
3 times, most recently
from
6b536ae to
f386f1c
Compare
gouthamve
reviewed
Feb 28, 2020
I thought the same and I would tend to agree. The only thing is that the value must be a power of 2, but we can validate it in |
codesome
reviewed
Feb 28, 2020
thorfour
force-pushed
the
feat/tsdb-stripe-size
branch
from
f386f1c to
4117191
Compare
|
Added validation that the given value is a power of 2. Thanks for the feedback! |
Signed-off-by: Thor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Thor [email protected]
What this PR does:
Exposes the new TSDB StripeSize option for reducing memory footprint.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]