Update the default configs for spread flush and bigchunks #2207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouthamve
reviewed
Mar 4, 2020
gouthamve
approved these changes
Mar 4, 2020
|
Hrm, tests are failing :( |
Will fix this up at the weekend. |
bboreham
approved these changes
Mar 9, 2020
pracucci
force-pushed
the
single-process-config
branch
from
6fedb2c to
0850ab0
Compare
|
Rebased |
Signed-off-by: Tom Wilkie <[email protected]>
Signed-off-by: Tom Wilkie <[email protected]>
Signed-off-by: Tom Wilkie <[email protected]>
Co-Authored-By: Bryan Boreham <[email protected]>
pracucci
force-pushed
the
single-process-config
branch
from
0850ab0 to
869fe64
Compare
Signed-off-by: Marco Pracucci <[email protected]>
|
In tests we do compare the chunk object. Switching to Bigchunk the comparison is not clean because of the appender pointer. In the commit 44ada47 I've used a trick to cleanup the expected chunk (the clean chunk has no appender internally). I'm not much happy with the trick I've done, but haven't come up with a better idea. |
gouthamve
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #2202
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]