Remove support schema flags, only use config file. #2221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouthamve
force-pushed
the
nuke-schema-flags
branch
3 times, most recently
from
a71faff to
5ff1cab
Compare
sandeepsukhani
approved these changes
Mar 6, 2020
gouthamve
force-pushed
the
nuke-schema-flags
branch
from
5ff1cab to
9e07d1c
Compare
bboreham
reviewed
Mar 6, 2020
gouthamve
force-pushed
the
nuke-schema-flags
branch
5 times, most recently
from
af006a3 to
42d465f
Compare
pracucci
reviewed
Mar 6, 2020
There was a problem hiding this comment.
Good job @gouthamve! Happy you approached integration tests for the first time 😉 I left few comments here and there: can't wait to see this PR merged!
Pay attention that:
dynamodb.original-table-nameis referenced intable-manager-dep.yamldynamodb.use-periodic-tables,dynamodb.periodic-table,dynamodb.chunk-tablehave several references across the doc
gouthamve
force-pushed
the
nuke-schema-flags
branch
4 times, most recently
from
9ef8d8c to
f852ca6
Compare
pracucci
approved these changes
Mar 9, 2020
| f.Var(&cfg.ChunkTablesFrom, "dynamodb.chunk-table.from", "Date after which to write chunks to DynamoDB.") | ||
| cfg.ChunkTables.RegisterFlags("dynamodb.chunk-table", "cortex_chunks_", f) | ||
| flag.StringVar(&cfg.fileName, "schema-config-file", "", "The path to the schema config file.") | ||
| // TODO(gouthamve): Add a metric for this. |
There was a problem hiding this comment.
Do we wanna keep this TODO? Is it really useful a metric for this?
Also rename the schema config file flag to something sane. Signed-off-by: Goutham Veeramachaneni <[email protected]>
Signed-off-by: Goutham Veeramachaneni <[email protected]>
Signed-off-by: Goutham Veeramachaneni <[email protected]>
Signed-off-by: Goutham Veeramachaneni <[email protected]>
Also rename the schema config file flag to something sane. Signed-off-by: Goutham Veeramachaneni <[email protected]>
Signed-off-by: Goutham Veeramachaneni <[email protected]>
Signed-off-by: Goutham Veeramachaneni <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
pracucci
force-pushed
the
nuke-schema-flags
branch
from
dac1ecf to
4bd8a88
Compare
Signed-off-by: Marco Pracucci <[email protected]>
3 tasks
garo
added a commit
to garo/cortex
that referenced
this pull request
May 6, 2020
Table manager can automatically add AWS tags to created DynamoDB tables. Previously this was done using a command line argument like “-dynamodb.index-table.tag=foo=bar” but this moved onto the schema configuration in PR cortexproject#2221 This PR updates this old reference on the cli argument. Signed-off-by: Juho Mäkinen <[email protected]>
pracucci
pushed a commit
that referenced
this pull request
May 11, 2020
Table manager can automatically add AWS tags to created DynamoDB tables. Previously this was done using a command line argument like “-dynamodb.index-table.tag=foo=bar” but this moved onto the schema configuration in PR #2221 This PR updates this old reference on the cli argument. Signed-off-by: Juho Mäkinen <[email protected]>
simonswine
pushed a commit
to grafana/e2e
that referenced
this pull request
Jan 13, 2022
…tex#2221) * Remove support schema flags, only use config file. Also rename the schema config file flag to something sane. Signed-off-by: Goutham Veeramachaneni <[email protected]> * Update docs to use the schema file. Signed-off-by: Goutham Veeramachaneni <[email protected]> * Deprecate not remove the config flag. Signed-off-by: Goutham Veeramachaneni <[email protected]> * Make integration tests pass? Signed-off-by: Goutham Veeramachaneni <[email protected]> * Remove support schema flags, only use config file. Also rename the schema config file flag to something sane. Signed-off-by: Goutham Veeramachaneni <[email protected]> * Update docs to use the schema file. Signed-off-by: Goutham Veeramachaneni <[email protected]> * Deprecate not remove the config flag. Signed-off-by: Goutham Veeramachaneni <[email protected]> * Update docs/configuration/schema-config-reference.md Signed-off-by: Marco Pracucci <[email protected]> * Fixed schema config doc Signed-off-by: Marco Pracucci <[email protected]> * Fixes after rebase Signed-off-by: Marco Pracucci <[email protected]> * Remove duplicated entry from CHANGELOG Signed-off-by: Marco Pracucci <[email protected]> Co-authored-by: Marco Pracucci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also rename the schema config file flag to something sane.
Which issue(s) this PR fixes:
Fixes #2208
Checklist
Tests updatedCHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]