Skip to content

Support 1w, 1y for retention and table period take 2 #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 12, 2020

Conversation

gouthamve
Copy link
Contributor

@gouthamve gouthamve commented Mar 11, 2020

What this PR does:
Support 1w and 1y for retention and table period. Will change docs and add changelog entries if this approach looks good as opposed to #2244

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Goutham! I also prefer this approach compared to #2244. I've added model.Duration support to doc generator for you: now there's no change in the generated config.

Signed-off-by: Goutham Veeramachaneni <[email protected]>
Signed-off-by: Goutham Veeramachaneni <[email protected]>
Signed-off-by: Goutham Veeramachaneni <[email protected]>
@pull-request-size pull-request-size bot added size/L and removed size/M labels Mar 12, 2020
@gouthamve gouthamve merged commit 6fee816 into cortexproject:master Mar 12, 2020
@@ -22,10 +22,10 @@ const (
schema: v9
index:
prefix: cortex_
period: 168h0m0s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this when I changed 1w to 168h when I wanted older versions to run in integration tests: d5f8f81

PR to update changelog here: #2265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants