Saner and consistent YAML fields in config

[gouthamve]

Signed-off-by: Goutham Veeramachaneni [email protected]

What this PR does:

Which issue(s) this PR fixes:
Fixes #

Checklist

• Tests updated
• Documentation added
• CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

[pstibrany]

If we're doing this, let's be consistent with our naming. URLs should have url in the name, duration fields should be _period, _interval, _time (max idle chunk time), booleans names like enable_ (not disable), etc. WDYT?

[jtlisi]

TY so much for taking this on. Now I can cross this off of my single-binary todo list haha. I have a few minor comments.

[pracucci]

Very good job @gouthamve! I left few comments, but the overall changes make much sense to me. Please remember to mention the changes in the CHANGELOG.

[bboreham]

booleans names like enable_ (not disable)

Historically these were chosen so the zero value (false) is the default.
At some point we went to mandatory initialization of config structs, so maybe that reason has gone, but I don't think there is a strong argument just on consistency.

For many flags the default is "what Cortex did earlier" but should be changed to "what most people would use". I think this type of change is much more important.

[pracucci]

LGTM! I left a minor nit. Please don't forget the CHANGELOG entry.