Skip to content

Renamed table-manager metrics to remove cortex_dynamo prefix #2307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 30, 2020
Merged

Renamed table-manager metrics to remove cortex_dynamo prefix #2307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
225476c
Renamed table-manager metrics to remove cortex_dynamo prefix
pracucci Mar 20, 2020
352aa8a
Added PR number to changelog
pracucci Mar 20, 2020
a16c7f9
Removed cortex_table_manager_table_capacity_units to cortex_table_man…
pracucci Mar 23, 2020
6b5e2c9
Rolledback renaming of cortex_dynamo_table_capacity_units metric
pracucci Mar 30, 2020
7a22cd5
Updated changelog
pracucci Mar 30, 2020
8bf6705
Update pkg/chunk/table_manager.go
pracucci Mar 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,8 @@
* [FEATURE] Added experimental storage API to the ruler service that is enabled when the `-experimental.ruler.enable-api` is set to true #2269
* `-ruler.storage.type` flag now allows `s3`,`gcs`, and `azure` values
* `-ruler.storage.(s3|gcs|azure)` flags exist to allow the configuration of object clients set for rule storage
* [CHANGE] Renamed table manager metrics. #2307
* `cortex_dynamo_sync_tables_seconds` -> `cortex_table_manager_sync_duration_seconds`
* [FEATURE] Flusher target to flush the WAL.
* `-flusher.wal-dir` for the WAL directory to recover from.
* `-flusher.concurrent-flushes` for number of concurrent flushes.
Expand Down
4 changes: 2 additions & 2 deletions pkg/chunk/table_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ func newTableManagerMetrics(r prometheus.Registerer) *tableManagerMetrics {
m := tableManagerMetrics{}
m.syncTableDuration = prometheus.NewHistogramVec(prometheus.HistogramOpts{
Namespace: "cortex",
Name: "dynamo_sync_tables_seconds",
Help: "Time spent doing SyncTables.",
Name: "table_manager_sync_duration_seconds",
Help: "Time spent synching tables.",
Buckets: prometheus.DefBuckets,
}, []string{"operation", "status_code"})

Expand Down