Removed gRPC server to communicate between querier and BucketStore #2324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <[email protected]>
pstibrany
approved these changes
Mar 25, 2020
codesome
pushed a commit
to codesome/cortex
that referenced
this pull request
Mar 31, 2020
…ortexproject#2324) Signed-off-by: Marco Pracucci <[email protected]>
This was referenced Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Currently, the querier starts a gRPC server binded to localhost just to talk to the Thanos
BucketStore(which is running within the same process). In this PR I'm proposing to get rid of this hack and just use a mockedstorepb.Store_SeriesServerbuffering the responsestorepb.Seriesin memory (which is what we were already doing anyway).Notes:
Info(),LabelNames()andLabelValues()have been removed because unused (metadata is fetched from ingesters only,Info()is a Thanos-specific thing)Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]