Configurable delay on rule evaluation #2423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob Lisi <[email protected]>
Signed-off-by: Jacob Lisi <[email protected]>
jtlisi
changed the title
pracucci
reviewed
Apr 8, 2020
pkg/ruler/ruler.go
Outdated
| cfg.ExternalURL.URL, _ = url.Parse("") // Must be non-nil | ||
| f.Var(&cfg.ExternalURL, "ruler.external.url", "URL of alerts return path.") | ||
| f.DurationVar(&cfg.EvaluationInterval, "ruler.evaluation-interval", 1*time.Minute, "How frequently to evaluate rules") | ||
| f.DurationVar(&cfg.EvaluationDelay, "ruler.evaluation-delay", 0, "Set interval to delay the evaluation of rules to ensure they underlying metrics have been pushed to cortex. Default ") |
There was a problem hiding this comment.
Suggested change
| f.DurationVar(&cfg.EvaluationDelay, "ruler.evaluation-delay", 0, "Set interval to delay the evaluation of rules to ensure they underlying metrics have been pushed to cortex. Default ") | |
| f.DurationVar(&cfg.EvaluationDelay, "ruler.evaluation-delay", 0, "Set interval to delay the evaluation of rules to ensure they underlying metrics have been pushed to cortex. ") |
| // the given engine, after subtracting the provided delay from the instant query timestamp. | ||
| // It converts scalar into vector results. | ||
| // Based on https://github.com/prometheus/prometheus/blob/ecda6013edf58bf645c6661b9f78ccce03b1f315/rules/manager.go#L162-L187 | ||
| func engineQueryFunc(engine *promql.Engine, q storage.Queryable, delay time.Duration) rules.QueryFunc { |
There was a problem hiding this comment.
This whole function is a copy of promRules.EngineQueryFunc() just to add t = t.Add(-delay) as first thing. Why don't we simply wrap promRules.EngineQueryFunc() instead of duplicating it? Something like (pseudo-code):
func engineQueryFunc(engine *promql.Engine, q storage.Queryable, delay time.Duration) rules.QueryFunc {
orig := promRules.EngineQueryFunc(engine, queryable)
return func(ctx context.Context, qs string, t time.Time) (promql.Vector, error) {
return orig(ctx, qs, t.Add(-delay))
}
}
gouthamve
reviewed
Apr 8, 2020
| # Set interval to delay the evaluation of rules to ensure they underlying | ||
| # metrics have been pushed to cortex. Default | ||
| # CLI flag: -ruler.evaluation-delay | ||
| [evaluation_delay: <duration> | default = 0s] |
There was a problem hiding this comment.
evaluation_delay_time/evaluation_delay_duration?
There was a problem hiding this comment.
evaluation_delay_duration makes sense
| // the given engine, after subtracting the provided delay from the instant query timestamp. | ||
| // It converts scalar into vector results. | ||
| // Based on https://github.com/prometheus/prometheus/blob/ecda6013edf58bf645c6661b9f78ccce03b1f315/rules/manager.go#L162-L187 | ||
| func engineQueryFunc(engine *promql.Engine, q storage.Queryable, delay time.Duration) rules.QueryFunc { |
Signed-off-by: Jacob Lisi <[email protected]>
pracucci
approved these changes
Apr 8, 2020
Signed-off-by: Jacob Lisi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR gives the operator the option to add an evaluation delay interval to the Ruler. This can be configured to ensure the ruler does not evaluate rules before the data required for the evaluation of those rules is written to Cortex.
Which issue(s) this PR fixes:
Fixes #1723
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]