Query frontend single binary #2437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
|
cc @jtlisi Ready for review! |
Signed-off-by: Marco Pracucci <[email protected]>
pracucci
reviewed
Apr 10, 2020
There was a problem hiding this comment.
👋 I've pushed a fix for the label names/values querying in the blocks storage (the edge case triggered in integration tests was when the written series timestamp >= now). The api.go refactoring LGTM. I just have a concern about the "single binary will be mysteriously unresponsive unless worker is working".
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
pracucci
approved these changes
Apr 10, 2020
gouthamve
reviewed
Apr 14, 2020
| a.RegisterRoute(a.cfg.LegacyHTTPPrefix+"/user_stats", http.HandlerFunc(distributor.UserStatsHandler), true) | ||
| a.RegisterRoute(a.cfg.LegacyHTTPPrefix+"/chunks", querier.ChunksHandler(queryable), true) | ||
|
|
||
| // these routes are either registered the default server OR to an internal mux. The internal mux is |
There was a problem hiding this comment.
Hrm, does this mean that when using the single binary mode, do we not expose the querier endpoints at all?
There was a problem hiding this comment.
That is correct. I purposefully chose this route over path prefixing because I found it cleaner.
Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
|
I don't have a strong opinion here, but we should add a TODO in the comments before merging this :) |
|
Other than that LGTM! |
Signed-off-by: Joe Elliott <[email protected]>
simonswine
pushed a commit
to grafana/e2e
that referenced
this pull request
Jan 13, 2022
* Added query frontend to the single binary Signed-off-by: Joe Elliott <[email protected]> * First pass single binary Signed-off-by: Joe Elliott <[email protected]> * Pass parameter correctly Signed-off-by: Joe Elliott <[email protected]> * lint Signed-off-by: Joe Elliott <[email protected]> * Added label tests to single binary Signed-off-by: Joe Elliott <[email protected]> * Added a warning for bad single process config Signed-off-by: Joe Elliott <[email protected]> * Added auto config of worker Signed-off-by: Joe Elliott <[email protected]> * Always add auth middleware. Signed-off-by: Joe Elliott <[email protected]> * Fixed label tests and used address that worked in e2e tests Signed-off-by: Joe Elliott <[email protected]> * updated changelog Signed-off-by: Joe Elliott <[email protected]> * Run unbounded queries to fetch label names/values in the blocks storage Signed-off-by: Marco Pracucci <[email protected]> * Moved automatic worker config attempt above worker Signed-off-by: Joe Elliott <[email protected]> * Moved changelog entry and expanded Signed-off-by: Joe Elliott <[email protected]> * Change => Enhancement Signed-off-by: Joe Elliott <[email protected]> * Added todo Signed-off-by: Joe Elliott <[email protected]> Co-authored-by: Marco Pracucci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]