frontend: also log the POST data of long queries #2481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The feature of query-frontend to log slower queries is already amazing but we can make it even better by logging the POST body as well. It is not uncommon nowadays to use POST with the Prometheus API. All of the data that is passed via POST is not visible via the URL. Thus, let's also print the POST data if it is available. Small testing shows that the message now looks like the following: ``` level=info ts=2020-04-17T16:34:51.200200445Z caller=frontend.go:174 msg="slow query" org_id=fake url=http://localhost:9009/api/prom/api/v1/query_range time_taken=1.638201ms body="end=1587141285&query=prometheus_http_requests_total&start=1587140385&step=15" ``` Signed-off-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Added PR number. Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS
force-pushed
the
frontend_log_more
branch
from
453eab5 to
e804475
Compare
Thanks, I have added the PR number to the changelog as well which I have missed before. |
tomwilkie
approved these changes
Apr 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature of query-frontend to log slower queries is already amazing
but we can make it even better by logging the POST body as well. It is
not uncommon nowadays to use POST with the Prometheus API. All of the
data that is passed via POST is not visible via the URL. Thus, let's
also print the POST data if it is available.
Small testing shows that the message now looks like the following:
Signed-off-by: Giedrius Statkevičius [email protected]