Skip to content

Conversation

pracucci
Copy link
Contributor

@pracucci pracucci commented Jun 4, 2020

What this PR does:
Applied a jitter to the period bucket scans in order to better distribute bucket operations over the time and increase the probability of hitting the shared cache (if configured).

Which issue(s) this PR fixes:
N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@pracucci pracucci requested a review from pstibrany June 4, 2020 14:26
Copy link
Contributor

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test. When it fails, math breaks.

@pracucci pracucci merged commit b9b3122 into cortexproject:master Jun 4, 2020
@pracucci pracucci deleted the add-jitter-to-blocks-storage-period-bucket-scans branch June 4, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants