Skip to content

Conversation

kwSeo
Copy link
Contributor

@kwSeo kwSeo commented Jun 25, 2020

What this PR does:

@bboreham
I'm sorry... I made a mistake about CHANGELOG in #2575.
I have fixed invalid change log that exist in the wrong section.
The 1.2.0-rc.0 release note also needs to update list of changes.

  • move the feature log about -cassandra.table-options
    • ## 1.1.0 / 2020-05-21 ---> ## 1.2.0 / 2020-06-xx

Signed-off-by: Kyeongwon Seo [email protected]

Which issue(s) this PR fixes:
Fixes

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

…from `## 1.1.0 / 2020-05-21` section to `## 1.2.0 / 2020-06-xx` section

Signed-off-by: Kyeongwon Seo <[email protected]>
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pracucci
Copy link
Contributor

I will let you @bboreham merge it, since you take care of the release process.

Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bboreham bboreham merged this pull request into cortexproject:release-1.2 Jun 25, 2020
bboreham pushed a commit that referenced this pull request Jun 25, 2020
…ection

from `## 1.1.0 / 2020-05-21` section to `## 1.2.0 / 2020-06-xx` section (#2787)

Signed-off-by: Kyeongwon Seo <[email protected]>
@kwSeo kwSeo deleted the fix_changelog_based_1.2 branch July 1, 2020 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants