Skip to content

Conversation

amckinley
Copy link
Contributor

Also clean up the language a bit.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pracucci
Copy link
Contributor

@amckinley Would you mind fixing the DCO in the commit, please?

@pracucci
Copy link
Contributor

@amckinley Sorry for the troubles, but DCO is still failing, because only 1 out of 4 commits have been signed off. An option to fix it would be squashing the commits:

git rebase -i HEAD~4

Then, in the edit, keep the 1st commit as is (do not edit it), while the change the action for the 3 remaining commits to s (it stands for "squash"). Once saved & exited, you will be prompted with another editor to update the commit message. Make sure it will have Signed-off-by: Austin McKinley <[email protected]>

Thanks!

Also clean up the language a bit.

Signed-off-by: Austin McKinley <[email protected]>
@amckinley
Copy link
Contributor Author

@pracucci no problem; my mistake. Should be good to go now.

@pracucci
Copy link
Contributor

Yes, thanks @amckinley !

@pracucci pracucci merged commit 77490f9 into cortexproject:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants