Skip to content

Make it possible to extend Makefile with custom settings. #3279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Make it possible to extend Makefile with custom settings. #3279

merged 1 commit into from
Oct 5, 2020

Conversation

pstibrany
Copy link
Contributor

What this PR does: This PR modifies Makefile to include Makefile.local if it exists, so that it is possible to extend it with custom settings and rules without committing those in shared repository. Example Makefile.local.example is included for inspiration.

If Makefile.local is missing, nothing changes.

Copy link
Contributor

@jtlisi jtlisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@pstibrany pstibrany merged commit d10d175 into cortexproject:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants