Skip to content

Conversation

pstibrany
Copy link
Contributor

@pstibrany pstibrany commented May 10, 2021

What this PR does: This PR changes default value of -server.grpc.keepalive.min-time-between-pings to 10s and -server.grpc.keepalive.ping-without-stream-allowed to true. This is in line with ping timeouts used by gRPC client in Cortex.

See #3606 (comment) for rationale.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@pstibrany pstibrany requested a review from pracucci May 10, 2021 11:58
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart approach! 👏 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants