Skip to content

Conversation

pstibrany
Copy link
Contributor

What this PR does: This PR introduces limits on Alertmanager templates uploaded by user via experimental Alertmanager API. Two limits are added: max number of alertmanager templates, and max size of individual template.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, LGTM!

@pstibrany pstibrany merged commit f16afd8 into cortexproject:master May 25, 2021
@pstibrany pstibrany deleted the alertmanager-templates-limits branch May 25, 2021 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants