Move iterators inside chunk store using MergeSeriesIterator #438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron7
force-pushed
the
move-iterators-inside-chunkstore
branch
from
5497751 to
c171b2e
Compare
aaron7
changed the title
aaron7
changed the title
aaron7
force-pushed
the
move-iterators-inside-chunkstore
branch
from
93df818 to
454f36c
Compare
tomwilkie
reviewed
May 24, 2017
| Metric: it.Metric().Metric, | ||
| Values: it.RangeValues(in), | ||
| } | ||
| matrix = append(matrix, ss) |
There was a problem hiding this comment.
This conversion is a little unfortunate. I think it needs a bit more thought.
tomwilkie
reviewed
May 24, 2017
pkg/util/iterator.go
Outdated
|
|
||
| for _, it := range msit.iterators { | ||
| samplePair := it.ValueAtOrBeforeTime(ts) | ||
| timeDifference := absTimeDifference(ts, samplePair.Timestamp) |
There was a problem hiding this comment.
Just realised that the samplePair timestamp will always be less than the timestamp given. I will remove.
tomwilkie
reviewed
May 24, 2017
pkg/util/merger.go
Outdated
| @@ -27,3 +27,26 @@ func MergeSamples(a, b []model.SamplePair) []model.SamplePair { | |||
| } | |||
| return result | |||
| } | |||
|
|
|||
| // MergeNSamples merges and dedupes n sets of already sorted sample pairs. | |||
| func MergeNSamples(sampleSets ...[]model.SamplePair) []model.SamplePair { | |||
There was a problem hiding this comment.
MergeNSamplesSets? And MergeSampleSets above?
tomwilkie
reviewed
May 24, 2017
pkg/util/merger.go
Outdated
| c <- MergeSamples(left, right) | ||
| }() | ||
| } | ||
| return <-c |
There was a problem hiding this comment.
Parallelism not necessary here I think.
aaron7
force-pushed
the
move-iterators-inside-chunkstore
branch
from
dda8599 to
4100dcc
Compare
aaron7
force-pushed
the
move-iterators-inside-chunkstore
branch
from
4100dcc to
596ddda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #430 - view changes for this PR here: https://github.com/weaveworks/cortex/pull/438/files/83bb69d02a11ef471aebf9408c6a1f1190a6a9da..c38224c193bafc21fe4e38be72c33117893f2dc6
Part of #416
MergeSeriesIteratorwhich is created from multiple iterators and implements SeriesIterator.