update thanos to include skip out of order chunks in compactor #4423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
reviewed
Aug 20, 2021
There was a problem hiding this comment.
I think this change doesn't work with the bucket index. The no-compact markers are not part neither of the global markers location (used by Cortex) and the bucket-index. I think the required steps to add support for this feature is:
- Add no-compact marker support to global location (see
BucketWithGlobalMarkers) - Add no-compact marker support to bucket-index (see
pkg/storage/tsdb/bucketindex)
pracucci
reviewed
Aug 20, 2021
There was a problem hiding this comment.
Also this PR upgrades Thanos too. We typically suggest to have a preliminary PR to upgrade Thanos only (so we can focus the review on it) and then having a PR to integrate new features. In the "Thanos upgrade PR" you can keep the "skip blocks with out of order chunks" disabled.
pracucci
reviewed
Aug 20, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yang Hu [email protected]
What this PR does:
Updates Thanos dependency to mark a corrupted block with out-of-order chunks for no compaction.
Thanos PR: thanos-io/thanos#4469, thanos-io/thanos#4566
Which issue(s) this PR fixes:
Fixes #3569
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]cc: @roystchiang @alvinlin123 @pracucci