Update cortex to use runtime config from dskit #4440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Reid <[email protected]>
pstibrany
reviewed
Aug 24, 2021
Signed-off-by: Tyler Reid <[email protected]>
aknuds1
added a commit
to aknuds1/cortex
that referenced
this pull request
Jan 13, 2022
…#4440)" This reverts commit a635a1e. Signed-off-by: Arve Knudsen <[email protected]>
pstibrany
pushed a commit
that referenced
this pull request
Jan 13, 2022
This reverts commit a635a1e. Signed-off-by: Arve Knudsen <[email protected]>
alvinlin123
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
* Update cortex to use runtime config from dskit Signed-off-by: Tyler Reid <[email protected]> * Add cortex prefix to generic metrics from dskit Signed-off-by: Tyler Reid <[email protected]> Signed-off-by: Alvin Lin <[email protected]>
alvinlin123
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
…#4440)" (cortexproject#4613) This reverts commit a635a1e. Signed-off-by: Arve Knudsen <[email protected]> Signed-off-by: Alvin Lin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tyler Reid [email protected]
What this PR does: This PR is a remove and replace for pkg/util/runtimeconfig in cortex after being moved to dskit/runtimeconfig.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]