Skip to content

Conversation

jdbaldry
Copy link
Contributor

@jdbaldry jdbaldry commented Oct 7, 2021

I believe this can often be a source of confusion during initial
configuration because even though the implicit HTTP API prefix set
when using --alertmanager.external-url is documented, it is non
obvious behavior.

For example, in #3919.

Signed-off-by: Jack Baldry [email protected]

Checklist

  • Documentation added

I believe this can often be a source of confusion during initial
configuration because even though the implicit HTTP API prefix set
when using `--alertmanager.external-url` is documented, it is non
obvious behavior.

For example, in cortexproject#3919.

Signed-off-by: Jack Baldry <[email protected]>
RulePath string `yaml:"rule_path"`

// URL of the Alertmanager to send notifications to.
// If your are configuring the ruler to send to a Cortex Alertmanager,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition. If you move this to the CLI flag description, than it would be part of the auto-generated config.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea would be nice to have this in auto generated doc. However, it's also nice to have this as inline doc, so I will get this merged and we can work on have it auto generated later on.

@alvinlin123 alvinlin123 merged commit 64befca into cortexproject:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants