Skip to content

update to latest Prometheus #4524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

replay
Copy link
Contributor

@replay replay commented Oct 11, 2021

This PR updates the vendored Prometheus to the latest version.

For this I had to update the test utils in pkg/configs/legacy_promql/test.go a bit. I removed the interface T and made it use the interface testutil.T from Prometheus instead.

Signed-off-by: Mauro Stettler <[email protected]>
Signed-off-by: Mauro Stettler <[email protected]>
@replay replay marked this pull request as ready for review October 11, 2021 19:37
@bboreham
Copy link
Contributor

Thanks for the PR. We would need either a CHANGELOG entry saying what changed, or a statement that no user-visible changes are included.

@replay
Copy link
Contributor Author

replay commented Oct 12, 2021

Thanks for the PR. We would need either a CHANGELOG entry saying what changed, or a statement that no user-visible changes are included.

Thanks for your feedback. I added a CHANGELOG entry specifically pointing out the changes which are relevant for Cortex: c0f3846

Signed-off-by: Mauro Stettler <[email protected]>
@replay replay force-pushed the 20211011_update_to_latest_prometheus branch from c0f3846 to a05a98b Compare October 13, 2021 12:28
@replay
Copy link
Contributor Author

replay commented Oct 13, 2021

FYI I force-pushed to DCO sign the last commit

@pracucci pracucci merged commit f9bef66 into cortexproject:master Oct 13, 2021
srijan55 pushed a commit to srijan55/cortex that referenced this pull request Nov 26, 2021
* update to latest prometheus

Signed-off-by: Mauro Stettler <[email protected]>

* go mod tidy

Signed-off-by: Mauro Stettler <[email protected]>

* add CHANGELOG entry

Signed-off-by: Mauro Stettler <[email protected]>
Signed-off-by: Manish Kumar Gupta <[email protected]>
alvinlin123 pushed a commit to ac1214/cortex that referenced this pull request Jan 14, 2022
* update to latest prometheus

Signed-off-by: Mauro Stettler <[email protected]>

* go mod tidy

Signed-off-by: Mauro Stettler <[email protected]>

* add CHANGELOG entry

Signed-off-by: Mauro Stettler <[email protected]>
Signed-off-by: Alvin Lin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants