Skip to content

Conversation

jmcarp
Copy link
Contributor

@jmcarp jmcarp commented Dec 10, 2021

What this PR does:

Docs-only update to reconcile the list of services in architecture.md with the output of cortex -modules. Sorry if I missed this elsewhere, but I hadn't seen a list of all cortex services in one place in the docs.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking: is this strictly required for running blocks storage, or is it only required if using blocks storage and the bucket index?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compactor also dedupes if you have replication across ingesters, and bulks up the blocks from 2 hours to 24 hours which reduces the cost of historic queries substantially. So you can technically run without it, but nobody should do.

@jmcarp jmcarp force-pushed the jmcarp/services-docs branch 2 times, most recently from 1ca0c74 to f76558d Compare December 10, 2021 06:42
Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've marked it as approved to speed up getting to 2 approvals, but really I don't want to add the Flusher and Purger.
Table Manager is debatable; it's quite likely someone reads about it in an older blog so we could justify mentioning it. Or equally we can say "don't add any new stuff about chunks".

Comment on lines 84 to 86
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chunks storage is deprecated; I think we should be taking it out of docs not adding more references.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I've dropped references to services used with chunks storage.

Note: services used with the chunks storage are excluded.

Signed-off-by: Josh Carp <[email protected]>
@jmcarp jmcarp force-pushed the jmcarp/services-docs branch from f76558d to 31c8b1f Compare December 16, 2021 21:54
@alvinlin123 alvinlin123 merged commit 7817c2a into cortexproject:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants