Skip to content

Ruler external support #4808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 18, 2022
Merged

Ruler external support #4808

merged 8 commits into from
Aug 18, 2022

Conversation

jmoscoso1
Copy link
Contributor

@jmoscoso1 jmoscoso1 commented Jul 28, 2022 •
edited
Loading

What this PR does:
Adds support for custom implementations of pusher and queryable

Example of custom implementation of pusher and queryable being used:

LoadConfig(configFile, expandENV, &cfg)

cfg.ExternalQueryable = querier.NewQueryable(c)
cfg.ExternalPusher = pusher.NewPusher(w)

t, err := cortex.New(cfg)

err = t.Run()

Full code at https://github.com/jmoscoso1/cortex_external_ruler
and the docker compose environment where it is run https://github.com/jmoscoso1/Docker_compose_cortex

Which issue(s) this PR fixes:
Fixes #4782

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@jmoscoso1 jmoscoso1 force-pushed the ruler_external_support branch from d009394 to 606d04f Compare July 28, 2022 21:49
harry671003
harry671003 reviewed Jul 28, 2022
View reviewed changes
@jmoscoso1 jmoscoso1 force-pushed the ruler_external_support branch from 606d04f to a68a378 Compare July 28, 2022 22:06
harry671003
harry671003 reviewed Aug 2, 2022
View reviewed changes
@pull-request-size pull-request-size bot added size/M and removed size/L labels Aug 5, 2022
harry671003
harry671003 reviewed Aug 8, 2022
View reviewed changes
alanprot
alanprot reviewed Aug 8, 2022
View reviewed changes
@pull-request-size pull-request-size bot added size/L and removed size/M labels Aug 9, 2022
@alanprot
Copy link
Member

Build and Lint not working! =/

@jmoscoso1 jmoscoso1 force-pushed the ruler_external_support branch from baee89a to c33bb25 Compare August 16, 2022 17:06
@jmoscoso1 jmoscoso1 force-pushed the ruler_external_support branch from c33bb25 to b15d4e7 Compare August 16, 2022 17:46
@jmoscoso1 jmoscoso1 force-pushed the ruler_external_support branch from b15d4e7 to cee8ec0 Compare August 16, 2022 20:28
@jmoscoso1
adding promql import
df70c79 
Signed-off-by: jmoscoso1 <[email protected]>
@jmoscoso1 jmoscoso1 force-pushed the ruler_external_support branch from 883e8db to df70c79 Compare August 16, 2022 22:07
@jmoscoso1
fixing lint problems
56434db 
Signed-off-by: jmoscoso1 <[email protected]>
@jmoscoso1 jmoscoso1 force-pushed the ruler_external_support branch from d6d86af to 56434db Compare August 18, 2022 01:47
@alvinlin123 alvinlin123 merged commit c815b3c into cortexproject:master Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harry671003 harry671003 harry671003 left review comments

@alvinlin123 alvinlin123 alvinlin123 approved these changes

@alanprot alanprot alanprot approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cross cluster rule evaluation
4 participants
@jmoscoso1 @alanprot @alvinlin123 @harry671003