Skip to content

Enhance Traces with pod information #4898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 6, 2022

Conversation

alanprot
Copy link
Member

@alanprot alanprot commented Oct 5, 2022

What this PR does:
Add pod Id and hostname as traces attributes.
Screen Shot 2022-10-05 at 4 53 30 PM

Which issue(s) this PR fixes:
Fixes #

Checklist

  • [NA] Tests updated
  • [NA] Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Alan Protasio <[email protected]>
@alanprot alanprot changed the title Enhance Traces with pod informations Enhance Traces with pod information Oct 5, 2022
Signed-off-by: Alan Protasio <[email protected]>
Signed-off-by: Alan Protasio <[email protected]>
Signed-off-by: Alan Protasio <[email protected]>
@yeya24
Copy link
Contributor

yeya24 commented Oct 6, 2022

I am not sure if this is something we want to add.
Since k8s is only one of the environments that OTEL attributes support https://opentelemetry.io/docs/reference/specification/resource/semantic_conventions/#environment, if we support k8s then do we need to support other environments?

@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 6, 2022
@alanprot
Copy link
Member Author

alanprot commented Oct 6, 2022

I am not sure if this is something we want to add. Since k8s is only one of the environments that OTEL attributes support https://opentelemetry.io/docs/reference/specification/resource/semantic_conventions/#environment, if we support k8s then do we need to support other environments?

That's a good point! I think leaving the hostname is fine though, right?

@alanprot alanprot merged commit 4b9a28a into cortexproject:master Oct 6, 2022
@alanprot alanprot deleted the tracing-resources branch October 6, 2022 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants