Upload global marker before local #4949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Deluiggi <[email protected]>
danielblando
force-pushed
the
global-marker
branch
from
5d72e84 to
eb497d4
Compare
alanprot
approved these changes
Nov 2, 2022
alvinlin123
approved these changes
Nov 4, 2022
t00350320
pushed a commit
to t00350320/cortex
that referenced
this pull request
Nov 15, 2022
Signed-off-by: Daniel Deluiggi <[email protected]> Signed-off-by: Daniel Deluiggi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Deluiggi [email protected]
What this PR does:
Change order Cortex upload markers to storage. In some situations, if the second call fails blocks can be left without being delete. This try to avoid it by always updating the global marker first
Which issue(s) this PR fixes:
Fixes #4872
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]