Skip to content

Add redis as index cache and caching bucket backend #5057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 14, 2023

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Dec 21, 2022

Signed-off-by: Ben Ye [email protected]

What this PR does:
Support redis as backend for caching bucket and index cache. Previously only in memory and memcached are supported cache backends.

Which issue(s) this PR fixes:
Fixes #5056 #5049

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@yeya24 yeya24 marked this pull request as draft December 21, 2022 07:12
@yeya24 yeya24 force-pushed the redis-index-cache branch from 1da4472 to 95b76ad Compare January 11, 2023 05:29
@yeya24 yeya24 force-pushed the redis-index-cache branch 4 times, most recently from 600b2e8 to 6f450a7 Compare January 15, 2023 21:47
@yeya24 yeya24 force-pushed the redis-index-cache branch from 6f450a7 to 7a2037f Compare January 15, 2023 21:50
@yeya24 yeya24 marked this pull request as ready for review January 15, 2023 21:51
@yeya24 yeya24 force-pushed the redis-index-cache branch 3 times, most recently from 916acfc to b3f94de Compare January 30, 2023 08:52
@yeya24
Copy link
Contributor Author

yeya24 commented Jan 30, 2023

This should be good for review.

@alanprot
Copy link
Member

LGTM

@yeya24 yeya24 merged commit b8e1dbd into cortexproject:master Feb 14, 2023
@yeya24 yeya24 deleted the redis-index-cache branch February 14, 2023 18:48
alexqyle pushed a commit to alexqyle/cortex that referenced this pull request May 2, 2023
* add redis as index cache and caching bucket backend

Signed-off-by: Ben Ye <[email protected]>

* add e2e test for redis index cache

Signed-off-by: Ben Ye <[email protected]>

* fix lint and integration test

Signed-off-by: Ben Ye <[email protected]>

* fix redis address

Signed-off-by: Ben Ye <[email protected]>

* update doc

Signed-off-by: Ben Ye <[email protected]>

* use cache backend to create cache

Signed-off-by: Ben Ye <[email protected]>

* update store gateway docs

Signed-off-by: Ben Ye <[email protected]>

---------

Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Alex Le <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support redis index cache
2 participants