Add redis as index cache and caching bucket backend #5057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
force-pushed
the
redis-index-cache
branch
from
1da4472 to
95b76ad
Compare
yeya24
force-pushed
the
redis-index-cache
branch
4 times, most recently
from
600b2e8 to
6f450a7
Compare
yeya24
force-pushed
the
redis-index-cache
branch
from
6f450a7 to
7a2037f
Compare
yeya24
force-pushed
the
redis-index-cache
branch
3 times, most recently
from
916acfc to
b3f94de
Compare
|
This should be good for review. |
alanprot
reviewed
Feb 13, 2023
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
yeya24
force-pushed
the
redis-index-cache
branch
from
b3f94de to
996c4be
Compare
Signed-off-by: Ben Ye <[email protected]>
alanprot
approved these changes
Feb 14, 2023
|
LGTM |
alexqyle
pushed a commit
to alexqyle/cortex
that referenced
this pull request
May 2, 2023
* add redis as index cache and caching bucket backend Signed-off-by: Ben Ye <[email protected]> * add e2e test for redis index cache Signed-off-by: Ben Ye <[email protected]> * fix lint and integration test Signed-off-by: Ben Ye <[email protected]> * fix redis address Signed-off-by: Ben Ye <[email protected]> * update doc Signed-off-by: Ben Ye <[email protected]> * use cache backend to create cache Signed-off-by: Ben Ye <[email protected]> * update store gateway docs Signed-off-by: Ben Ye <[email protected]> --------- Signed-off-by: Ben Ye <[email protected]> Signed-off-by: Alex Le <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Ye [email protected]
What this PR does:
Support redis as backend for caching bucket and index cache. Previously only in memory and memcached are supported cache backends.
Which issue(s) this PR fixes:
Fixes #5056 #5049
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]