Allow shard sizes to be percent of instances #5393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harry671003
force-pushed
the
dynamic_sharding
branch
from
85a2161 to
1189bab
Compare
friedrichg
reviewed
Jun 9, 2023
There was a problem hiding this comment.
I like that we are not adding another flag.
The operator in me says this flag needs a percentage sign like kubernetes does it. For humans to understand it better.
The developer in me says this number comes another system, this should be machine readable 😄
I can see value in both.
pkg/util/shard.go
Outdated
| @@ -43,3 +43,12 @@ func ShuffleShardExpectedInstancesPerZone(shardSize, numZones int) int { | |||
| func ShuffleShardExpectedInstances(shardSize, numZones int) int { | |||
| return ShuffleShardExpectedInstancesPerZone(shardSize, numZones) * numZones | |||
| } | |||
|
|
|||
| // DynamicShardSize returns the shard size as a percentage of numInstances if the value is < 1. If the value is > 1, the value is rounded and returned. | |||
There was a problem hiding this comment.
Suggested change
| // DynamicShardSize returns the shard size as a percentage of numInstances if the value is < 1. If the value is > 1, the value is rounded and returned. | |
| // DynamicShardSize returns the shard size as a percentage of numInstances if the value is < 1. If the value is >= 1, the value is rounded and returned. |
Signed-off-by: 🌲 Harry 🌊 John 🏔 <[email protected]>
harry671003
force-pushed
the
dynamic_sharding
branch
from
1189bab to
df3dc25
Compare
I agree. :) |
yeya24
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR allows querier and store-gateway tenant shard sizes to be configured as a percentage of a total
For backwards compatibility, the data type was changed to float64.
Which issue(s) this PR fixes:
Fixes #5374
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]