add write consumed capacity to ddb metrics #5481
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wen Xu <[email protected]>
pkg/ring/kv/dynamodb/metrics.go
Outdated
| dynamodbUsageMetrics := promauto.With(registerer).NewCounterVec(prometheus.CounterOpts{ | ||
| Name: "dynamodb_kv_read_capacity_total", | ||
| Help: "Total used read capacity on dynamodb", | ||
| Name: "dynamodb_kv_read_write_capacity_total", |
There was a problem hiding this comment.
Should we add a changelog for this?
I think the problem is that we are changing the name of the metric and if someone is already using it, it might break their usecase.
Also how about dynamodb_kv_consumed_capacity_total. Might be more a clear relation with ddb info.
There was a problem hiding this comment.
makes sense. I will make the change and add statement in ChangeLog.
Signed-off-by: Wen Xu <[email protected]>
Signed-off-by: Wen Xu <[email protected]>
yeya24
approved these changes
Jul 26, 2023
* clean up no step evaluation interval in QFE codec Signed-off-by: Ben Ye <[email protected]> * fix tests Signed-off-by: Ben Ye <[email protected]> --------- Signed-off-by: Ben Ye <[email protected]>
…t#5486) Signed-off-by: Alan Protasio <[email protected]>
Signed-off-by: Wen Xu <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Before we only have Query, Get, List label value for the ddb_read_capacity_consumed metrics
Now adding more dimensions, including Batch, Delete, Put,
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]