Make multilevel cache backfilling async #5661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's wait for thanos-io/thanos#6908 to avoid duplicating too much code |
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
yeya24
force-pushed
the
async-backfilling
branch
from
ee20fd8 to
372f6d5
Compare
Signed-off-by: Ben Ye <[email protected]>
Signed-off-by: Ben Ye <[email protected]>
alanprot
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This change changes multilevel cache backfilling from sync operation to async operation.
Rather than waiting for cache backfilling requests to finish, it now use the async operation processor https://github.com/thanos-io/thanos/blob/main/pkg/cacheutil/async_op.go#L10 to backfill in an async way.
Backfilling functions will be added into a Golang channel with a configured size. And an amount of workers pull jobs from the channel and backfills to cache.
Since the channel size is limited, if an operation cannot enqueue, it will be discarded and we increment a metric called
cortex_store_multilevel_index_cache_backfill_dropped_items_total. It should be fine to discard the backfill operation to prevent high load. As long as the same key is requested by user, the cache can be backfilled eventually.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]