-
Notifications
You must be signed in to change notification settings - Fork 816
Ruler HA - Proposal #5862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruler HA - Proposal #5862
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the spec.
Run make clean-white-noise to pass the lint
docs/proposals/ruler-ha-new.md
Outdated
|
||
The author proposes making a change to Prometheus to allow for pausing and resuming (or activating and deactivating) a rule group as described [here](https://github.com/prometheus/prometheus/issues/13630) | ||
|
||
If the proposal is not accepted by Prometheus community, the proposal is to maintain a fork of Prometheus for Cortex with modified rule group evaluation behavior. This [draft PR](https://github.com/prometheus/prometheus/pull/13858) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maintain a fork of Prometheus for Cortex
Maintaining a full prometheus fork should be the last option, we don't have the capacity to maintain such fork. I think we could instead copy some of the prometheus ruler code here and call it experimental. do you think that could work or is that not a possibility?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is doable. Probably need to copy all the ruler code from this package. I will need to figure out how to keep the code in sync with Prometheus upstream in terms of new features/updates
bcda709
to
dbc67ff
Compare
Let's update the proposal with your latest proposed changes? IMO this should be merged before #6129. |
Signed-off-by: Anand Rajagopal <[email protected]>
dbc67ff
to
2ba58a0
Compare
Signed-off-by: Anand Rajagopal <[email protected]>
2ba58a0
to
6508c4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see we use the same Title Ruler HA
as the old proposal https://cortexmetrics.io/docs/proposals/ruler-ha/.
We changed the file name but I think the title will be the same when looking at https://cortexmetrics.io/docs/proposals/.
Should we only keep one proposal visible? Or let's change the title for this proposal or the old proposal
…the new proposal Signed-off-by: Anand Rajagopal <[email protected]>
What this PR does:
Which issue(s) this PR fixes:
Proposal for Ruler HA
I can add more details as necessary
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]